migrate from inject to service named import in @ember/service - #1709
Open
jelhan wants to merge 1 commit into
Open
migrate from inject to service named import in @ember/service#1709jelhan wants to merge 1 commit into
jelhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
servicenamed export has been added in v4.1 as an alternative toinject. Theinjectnamed export was deprecated in the v6 cycle and dropped in 7.0.This should not be a breaking change as ember-cli-addon-docs already requires Ember v4.8+.
This is required for Ember v7 compatibility. But I have not tested if it is the only needed change.